fix: Fixed panic when DSN="memory" is configured #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excuting the migration logic in registry.go cause a panic as the registry is not initalized at that point. Therefore we decided to move the handling to driver_default.go, after the registry has been initalized.
zepatrik
reviewed
Jul 13, 2020
|
I don't understand why CircleCI doesn't trigger for you... |
Changed SQLite string used for shortcut "memory" to "sqlite://:memory:?_fk=true" Adjusted tests Minor fix to Makefile: changed docker image name to include -sqlite in tag for target docker as Kratos is compiled with SQLite support. Added test case "memory" to e2e tests Adjusted run.sh to only call kratos migrate sql if test case != "memory
aeneasr
approved these changes
Jul 14, 2020
aeneasr
reviewed
Jul 14, 2020
…dsnmemory-handling
gosimple S1008
|
Awesome 🎉 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
If you configured Kratos to use DSN=memory Kratos crashed with a panic as the code used the registry before it was initialized properly.
Proposed changes
Ensure auto migrate logic for DSN=memory is executed after Registry has been initalized successfully.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.